[PATCH wayland v3 0/4] Enum and bitfield XML attributes
Bryce Harrington
bryce at osg.samsung.com
Wed Nov 4 15:03:12 PST 2015
On Sat, Oct 24, 2015 at 12:07:46PM +0100, Auke Booij wrote:
> There has been plenty of discussion regarding the introduction of new XML
> attributes. This series of patches improves on my earlier attempt to find
> common ground in this.
>
> Major exclusions from these patches are:
>
> - Support for cross-interface enum referencing (e.g.
> wl_shm_pool::create_buffer::format to wl_shm::format, and
> wl_surface::set_buffer_transform::transform to wl_output::transform).
> There is consensus that this should be added sooner rather than later.
> My proposal is to get these patches in first, and then look at that.
>
> - Open/closed enum specification. There is still too much debate on this.
> Until there is any firm specification of open/closed enums, every enum
> should be considered open, and although some legal values might be
> listed, others might not be, and some might only be legal sometimes.
> New values may be added (but not changed or removed) to protocol
> specifications without introducing any compatibility issues.
>
> Changes since v2:
> - Incorporate new documentation drawn up during v2 discussion
> - Enable wl_shell_surface::transform bitfield
>
> Changes since v1:
> - Split up documentation patches
> - Set enum="fullscreen_method" on
> wl_shell_surface::set_fullscreen::method
>
> Auke Booij (4):
> doc: document the enum and bitfield attributes
> protocol: specify enum and bitfield attributes
> scanner: enforce correct argument type for enums
> doc: output enum and bitfield attributes in the documentation
>
> doc/publican/protocol-to-docbook.xsl | 9 +++++
> doc/publican/sources/Protocol.xml | 41 +++++++++++++++++----
> protocol/wayland.xml | 36 +++++++++----------
> src/scanner.c | 70 ++++++++++++++++++++++++++++++++++++
> 4 files changed, 132 insertions(+), 24 deletions(-)
Thanks, was hoping to get another r-b or two but guess we've adequately
exhausted interest in this particular changeset. Let's get this landed
so y'all can proceed with the next step in the enum work.
remote: Updating patchwork state for http://patchwork.freedesktop.org/project/wayland/list/
remote: I: patch #62885 updated using rev 999225c17a6ee23d5b5171b80b5158f93beb7abc
remote: I: patch #62835 updated using rev 851614fa78862499e016c5718e730fefbb8e3b73
remote: E: failed to find patch for rev 1771299a5a965c1f95c18ef795c29db876133a81
remote: I: patch #62244 updated using rev 4a97cb35794866414b84242a89d1dbcc7f9c59fe
remote: I: 3 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/wayland/wayland
f150d7a..4a97cb3 master -> master
Bryce
More information about the wayland-devel
mailing list