[PATCH weston 01/10] Use fullscreen-shell.xml from wayland-protocols

[Pekka Paalanen]

On Fri, 6 Nov 2015 10:51:09 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> On Thu, Nov 05, 2015 at 11:46:46AM -0800, Bryce Harrington wrote:
> > On Wed, Nov 04, 2015 at 04:49:50PM +0800, Jonas Ådahl wrote:
> > > Use the fullscreen-shell protocol XML from the wayland-protocols
> > > installation, and remove the one we provide ourself.
> > > 
> > > Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> > >
> > > diff --git a/clients/fullscreen.c b/clients/fullscreen.c
> > > index 4fcca3d..be316d0 100644
> > > --- a/clients/fullscreen.c
> > > +++ b/clients/fullscreen.c
> > > @@ -35,7 +35,7 @@
> > >  #include <linux/input.h>
> > >  #include <wayland-client.h>
> > >  #include "window.h"
> > > -#include "fullscreen-shell-client-protocol.h"
> > > +#include "fullscreen-shell-unstable-v1-client-protocol.h"
> > 
> > Angle brackets should be used here and elsewhere, since with this change
> > the header file now is located externally from the system rather than
> > being locally present in the codebase.
> > 
> >   #include <fullscreen-shell-unstable-v1-client-protocol.h>
> 
> Good point.

Is it, really?

These headers will not be found installed in the system, ever. They
will always be generated locally in the Weston build tree during the
build, the same way we used to do it without wayland-protocols repo.

wayland-protocols package is only ever meant to install XML files, not
headers.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151106/95c19919/attachment.sig>