[PATCH v2 wayland 1/3] shm: Deprecate wl_shm_buffer_create()

[Derek Foreman]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 06/11/15 06:10 AM, Pekka Paalanen wrote:
> On Fri, 6 Nov 2015 10:29:56 +0200 Giulio Camuffo
> <giuliocamuffo at gmail.com> wrote:
> 
>> For the whole series: Reviewed-by: Giulio Camuffo
>> <giuliocamuffo at gmail.com>
>> 
>> 2015-11-05 21:57 GMT+02:00 Derek Foreman
>> <derekf at osg.samsung.com>:
>>> From irc: <pq> it creates a wl_buffer object in a way that no
>>> client can ever access the storage.
>>> 
>>> So, let's replace it with return NULL; and mark it with
>>> attribute deprecated in the header.
>>> 
>>> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk> 
>>> Signed-off-by: Derek Foreman <derekf at osg.samsung.com> ---
>>> 
>>> Change from v1: return NULL instead of abort()ing
>>> 
>>> src/wayland-server-core.h |  2 +- src/wayland-shm.c         |
>>> 29 +---------------------------- 2 files changed, 2
>>> insertions(+), 29 deletions(-)
> 
> Hi,
> 
> I was going to complain that patch 2 doesn't work, but it does work
> - I just needed to 'make clean' to see the effect.

I wonder why that is - a dependency problem in our Makefiles?

> All three pushed: 4a97cb3..8bc42fb  master -> master
> 

Thanks

> Thanks, pq
> 

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJWPL5OAAoJEF5USY5pfxHX0vYIAIXIEi+QIWQaSri+mYjazIu8
Dc2Xw5uL/yOy0m/2DasrgwlKO5yoJdBGotPHy4RBj445GaVDAQ6Jh4oNmmmGzTol
ZsLA9W7V9RI3J6m75kyTMZO2FwRAkN5JPcc1iCgQr5O2o+OT3LvJlg/cJk3NEou5
J1hQwr1RIBvhxpyyV0ziAfEUoBDn/DEl2qlXjTtasLX5c6g+yA/mJDZF0jdSWx8e
2mG1MTgIUHDKjYSizuwNcAGuzrMAlhmaI0J9S3DjS5m/WotlWU2uN1txyDQutEB7
IWgOPU9n26y0w0KC0TBTZxQJbth1z9UyDvNiw6DErKGO5QJ3r6LaoZoXlSXzl70=
=YdhX
-----END PGP SIGNATURE-----