[PATCH] compositor: Disallow negative geometries in backend output configs

Pekka Paalanen ppaalanen at gmail.com
Fri Nov 6 07:40:10 PST 2015


On Fri, 6 Nov 2015 14:50:26 +0000
Auke Booij <auke at tulcod.com> wrote:

> On 24 October 2015 at 08:23, Jasper St. Pierre <jstpierre at mecheye.net> wrote:
> > I'm struggling to understand the motivation for this patch.
> >
> > krh has always said that you need to think of uint and int as two
> > entirely separate types -- mixing both in math will likely screw up.
> > You can see this in other places -- widths are often expressed as
> > signed ints in the protocol, not unsigned ints.
> 
> Is it maybe time to fix the protocol before it becomes a problem? Not
> sure what a sane process towards this would be...

What's wrong with the protocol? It is already using signed integers
everywhere for dimensions and coordinates that I recall.

Anyway, we must not change the type if the protocol is already stable.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151106/39047b68/attachment.sig>


More information about the wayland-devel mailing list