[PATCH weston 01/10] Use fullscreen-shell.xml from wayland-protocols

[Bryce Harrington]

On Fri, Nov 06, 2015 at 10:24:21AM +0200, Pekka Paalanen wrote:
> On Fri, 6 Nov 2015 10:51:09 +0800
> Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> > On Thu, Nov 05, 2015 at 11:46:46AM -0800, Bryce Harrington wrote:
> > > On Wed, Nov 04, 2015 at 04:49:50PM +0800, Jonas Ådahl wrote:
> > > > Use the fullscreen-shell protocol XML from the wayland-protocols
> > > > installation, and remove the one we provide ourself.
> > > > 
> > > > Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> > > >
> > > > diff --git a/clients/fullscreen.c b/clients/fullscreen.c
> > > > index 4fcca3d..be316d0 100644
> > > > --- a/clients/fullscreen.c
> > > > +++ b/clients/fullscreen.c
> > > > @@ -35,7 +35,7 @@
> > > >  #include <linux/input.h>
> > > >  #include <wayland-client.h>
> > > >  #include "window.h"
> > > > -#include "fullscreen-shell-client-protocol.h"
> > > > +#include "fullscreen-shell-unstable-v1-client-protocol.h"
> > > 
> > > Angle brackets should be used here and elsewhere, since with this change
> > > the header file now is located externally from the system rather than
> > > being locally present in the codebase.
> > > 
> > >   #include <fullscreen-shell-unstable-v1-client-protocol.h>
> > 
> > Good point.
> 
> Is it, really?
> 
> These headers will not be found installed in the system, ever. They
> will always be generated locally in the Weston build tree during the
> build, the same way we used to do it without wayland-protocols repo.

Oh!  In that case yeah quotes are fine.  Forgot that they're generated
files.

Bryce
 
> wayland-protocols package is only ever meant to install XML files, not
> headers.
> 
> 
> Thanks,
> pq

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> 
> iQIVAwUBVjxjvSNf5bQRqqqnAQjK4Q/+M8za5+kttG0rjQqqG34wX7GC0ADmcRme
> nUWz7DO5AWAQv/n3Ct8veuYWVnAhKBSJQEPmDvNCw2xNXrzEs11hispY1tlimt2m
> NU5e7x87p29Vid9pEAclqrYXD1m3dM9wp2MWQIxZwco3DW5/0sep+cOAu9XDygpC
> Z0gtzL2WUGi7KgbqPjceBcC/GgRx7aGm2KwSLM6HN2K0E2HeMcBYnBjnnqNe6fBm
> 98wYVW6ohnxu2kk3C4HdvexMlB5frH7LURaFXsWGc2CQyN+kLwBQgAeapHuG68Dk
> QE6XYYYVN6bTiJNYgWcVlN22ZYPoZeS6eAEyfVmbBVmPJ6atpr0w44L534npB4jO
> ekmUgsnk0NVNfZcLK/uxFrGaPPIbyR5FmbyI1FIYeDDn5VOePVzjjAK2aB/Cu+5s
> R471bTKAbvQVwvTnxHBG0MZC8Nobgm0oRseiXbkOwP2hkH3v/A42S7nP6Rf62CUp
> qimV3K4zlL1zKcV/l8XMSpI9HP3Xrs/7Mc9FViZaLpOEW5Q/NK3RQfhjlLI+NoFR
> 9w25yEvRvwap7Z9ZM/ZAeC2UT2ZklSvmwfTw/8lmzkp6dW/TAwbRrZFtkDuNc3T9
> Virw1asKxGxstaEBs5SEcJV2v6oB5yjEWvDfMqEeEMeD1dDjLbwrcRL1vBYiMgQN
> BqA995O6OcY=
> =3Qrz
> -----END PGP SIGNATURE-----