[PATCH libinput] Documentation fixes to arrows in svg files

[Tomi Leppänen]

17.09.2015, 21:56, Bryce Harrington kirjoitti:
> On Thu, Sep 17, 2015 at 03:05:25PM +0300, Tomi Leppänen wrote:
>> There were two files (doc/svg/{edge,twofinger}-scrolling.svg) that had both
>> arrow heads pointing to wrong direction. Those arrow heads used markers but
>> their ids were defined wrong and therefore they displayed weirdly. On Firefox
>> the arrow head that should have pointed to left pointed actually to right.
>>
>> This commit fixes that problem by defining the marker ids correctly.
>>
>> I tested on Firefox 40.0.3 that the arrow heads are now displayed correctly.
>> ---
>>   doc/svg/edge-scrolling.svg      | 2 +-
>>   doc/svg/twofinger-scrolling.svg | 2 +-
>>   2 files changed, 2 insertions(+), 2 deletions(-)
> Hi Tomi,
>
> Thanks, good catch.  I checked the SVG files in Inkscape, and confirm
> that the arrow direction is wrong, and your patch corrects them.
Hi

Thank you. It seems that my patch has been unnoticed, apart from you 
reviewing it, for some time now and I'm not sure what should I do or if 
I should do anything at all.
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
> Tested-by: Bryce Harrington <bryce at osg.samsung.com>
>
> Btw, it's a good practice to indicate in the subject when your patch is
> against weston or libinput rather than wayland.
Yeah, thanks. I figured that out after sending the email. I'll remember 
that next time! This was indeed my first patch sent to any email list.
> Thanks for the fix!
> Bryce
Regards
Tomi
>> diff --git a/doc/svg/edge-scrolling.svg b/doc/svg/edge-scrolling.svg
>> index cba72c5..c768e80 100644
>> --- a/doc/svg/edge-scrolling.svg
>> +++ b/doc/svg/edge-scrolling.svg
>> @@ -105,7 +105,7 @@
>>       <path
>>          d="m 455.56456,762.87232 c 0,0 -235.01231,1.01015 -235.01231,1.01015"
>>          id="path3702"
>> -       style="fill:none;stroke:#000000;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;marker-start:url(#Arrow1Lstart);marker-end:url(#Arrow1Lstart)" />
>> +       style="fill:none;stroke:#000000;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;marker-start:url(#Arrow1Lstart-4);marker-end:url(#Arrow1Lend-2)" />
>>       <g
>>          transform="matrix(0.98314313,0.18283763,-0.18283763,0.98314313,132.81621,-12.620089)"
>>          id="g3663-9">
>> diff --git a/doc/svg/twofinger-scrolling.svg b/doc/svg/twofinger-scrolling.svg
>> index e182a7f..7830c25 100644
>> --- a/doc/svg/twofinger-scrolling.svg
>> +++ b/doc/svg/twofinger-scrolling.svg
>> @@ -127,7 +127,7 @@
>>         <path
>>            d="m 400.17949,657.93904 c 0,0 -235.01231,1.01015 -235.01231,1.01015"
>>            id="path3702"
>> -         style="fill:none;stroke:#000000;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;marker-start:url(#Arrow1Lstart);marker-end:url(#Arrow1Lstart)" />
>> +         style="fill:none;stroke:#000000;stroke-width:1;stroke-linecap:butt;stroke-linejoin:miter;stroke-miterlimit:4;stroke-opacity:1;stroke-dasharray:none;marker-start:url(#Arrow1Lstart-4);marker-end:url(#Arrow1Lend-2)" />
>>         <g
>>            transform="matrix(0.98196551,0.12493315,-0.14261338,1.1209308,78.621186,-191.74129)"
>>            id="g3663">
>> -- 
>> 2.4.3
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel