[PATCH weston] compositor-drm: fall back to EGL visual_id 0 if no others work

[Bryce Harrington]

On Wed, Nov 04, 2015 at 12:58:18PM -0800, Bryce Harrington wrote:
> On Wed, Nov 04, 2015 at 02:47:33PM -0600, Derek Foreman wrote:
> > commit e76f185 stopped using visuals with "native visual id" == 0
> > 
> > This broke some systems, so we now try 0 as a worst case fallback if
> > everything else has failed.
> > 
> > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
> 
> Aha, I was wondering if the 0 might not be the most desireable thing to
> pick...

Pushed
remote: I: patch #63708 updated using rev 6d556374b8ad46d2b2f8cd8f77a344c81a3311d7
remote: I: 1 patch(es) updated to state Accepted.
To ssh://git.freedesktop.org/git/wayland/weston
   0336ca0..6d55637  master -> master

 
> > ---
> > 
> > I'm not able to confirm myself that this fixes the bug it's intended to...
> > 
> >  src/compositor-drm.c | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/src/compositor-drm.c b/src/compositor-drm.c
> > index 41f9a82..a279dba 100644
> > --- a/src/compositor-drm.c
> > +++ b/src/compositor-drm.c
> > @@ -1559,14 +1559,15 @@ fallback_format_for(uint32_t format)
> >  static int
> >  drm_backend_create_gl_renderer(struct drm_backend *b)
> >  {
> > -	EGLint format[2] = {
> > +	EGLint format[3] = {
> >  		b->format,
> >  		fallback_format_for(b->format),
> > +		0,
> >  	};
> > -	int n_formats = 1;
> > +	int n_formats = 2;
> >  
> >  	if (format[1])
> > -		n_formats = 2;
> > +		n_formats = 3;
> >  	if (gl_renderer->create(b->compositor,
> >  				EGL_PLATFORM_GBM_KHR,
> >  				(void *)b->gbm,
> > -- 
> > 2.6.1
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel