[PATCH libinput] touchpad: reduced the 2fg scroll threshold to 1mm

Hans de Goede hdegoede at redhat.com
Mon Nov 9 00:26:18 PST 2015


Hi,

On 09-11-15 07:40, Peter Hutterer wrote:
> At least on the t440, this is enough to trigger correct detection between
> swipe and scroll 90% of the time.

s/swipe/pinch/

 > Since scrolling is significantly more
> prevalent than gesturing, erring on the side of scrolling at the cost of
> misdetecting some gestures is acceptable.
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Otherwise I say lets give this a try and see how it goes (we will likely not
know until higher levels in the stack actually start supporting pinch gestures,
but ah well):

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


> ---
>   src/evdev-mt-touchpad-gestures.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/evdev-mt-touchpad-gestures.c b/src/evdev-mt-touchpad-gestures.c
> index cc26e2a..80aa89f 100644
> --- a/src/evdev-mt-touchpad-gestures.c
> +++ b/src/evdev-mt-touchpad-gestures.c
> @@ -195,7 +195,7 @@ tp_gesture_get_direction(struct tp_dispatch *tp, struct tp_touch *touch)
>   	    (tp->device->model_flags & EVDEV_MODEL_ELANTECH_TOUCHPAD) == 0)
>   		move_threshold = TP_MM_TO_DPI_NORMALIZED(4);
>   	else
> -		move_threshold = TP_MM_TO_DPI_NORMALIZED(2);
> +		move_threshold = TP_MM_TO_DPI_NORMALIZED(1);
>
>   	delta = device_delta(touch->point, touch->gesture.initial);
>
>


More information about the wayland-devel mailing list