Patchwork missing the rest of the series (Re: [PATCH wayland 0/3] Restore DTD and use wayland-scanner to validate)

[Damien Lespiau]

On Mon, Nov 09, 2015 at 11:25:17AM +0200, Pekka Paalanen wrote:
> Hi Damien,

Hi Pekka,

> I just noticed that from this patch series of three, only 1/3 shows up
> in Patchwork as http://patchwork.freedesktop.org/patch/64191/ .
> The rest are:
> http://lists.freedesktop.org/archives/wayland-devel/2015-November/025336.html
> http://lists.freedesktop.org/archives/wayland-devel/2015-November/025337.html
> 
> Any idea what's going on?
> 
> Looks like annarchy at least does not suffer from a full disk atm.,
> don't know if it did earlier. I'm not even sure if that is the right
> machine to look at, but in the past I think annarchy's root disk being
> full coincided with missing some patches.

I do have an idea!

Patchwork hit an assertion and so the patch wasn't processed. The good
news is that I now receive a mail with the backtrace when it happens, so
I can have a look and fix the problem. And so I did and it turned out to
be a tricky one involving series patches sent to a mail thread across
the boundary where patchwork learned about Series. The minimal-ish test
case is:


    + patch                            \
    +--+ reply 1                        | Before patchwork knew
       +--+ patch                       | about series
          +--+ reply 2                 /
             +--+ cover letter (0/3)   \
                +--> patch 1/3          | After patchwork knew
                +--> patch 2/3          | about series
                +--> patch 3/3         /


Series support is pretty young, so I'm still ironing out some corner cases.

I fixed this (with a unit test even!) in:

  https://github.com/dlespiau/patchwork/commit/4da2a45c6db571af64340c4b8c05315c3460ba56

I also replayed the two lost paches so you at least have them appear. I
couldn't replay the replies as I don't receive all the wayland emails
and we don't archive the real emails but just the mailman-mangled ones.

  http://patchwork.freedesktop.org/series/593/

Something else I noticed on this thead:

In the reply 20151019013047.GA8175 at jelly.local from Peter, there's a
diff put there for reference, picked up as a patch by patchwork:

  http://patchwork.freedesktop.org/patch/msgid/20151019013047.GA8175@jelly.local

If you want patchwork to not consider those kind of diffs as real
patches, there's a per-project option I can activate: only consider git
send-email mails as potential patches.

HTH,

-- 
Damien