[PATCH wayland-protocols] Add the tablet protocol

[Carlos Garnacho]

Hey,

On Fri, Nov 6, 2015 at 5:24 AM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> This is the revamped version of the tablet protocol for graphics tablets
> (e.g. Wacom tablets). Too many changes from the last version (a year ago or
> so), so I won't detail them, best to look at it with fresh eyes.
>
>  Makefile.am                            |   1 +
>  unstable/tablet/README                 |   4 +
>  unstable/tablet/tablet-unstable-v1.xml | 588 +++++++++++++++++++++++++++++++++
>  3 files changed, 593 insertions(+)
>  create mode 100644 unstable/tablet/README
>  create mode 100644 unstable/tablet/tablet-unstable-v1.xml
>
> diff --git a/Makefile.am b/Makefile.am
> index 4bcab32..588cb2c 100644

<snip>

> +    <enum name="type">
> +      <description summary="tablet type">
> +       Describes the type of tablet
> +      </description>
> +
> +      <entry name="external" value="0" summary="The tablet is an external tablet, such as an Intuos"/>
> +      <entry name="internal" value="1" summary="The tablet is a built-in tablet, usually in a laptop"/>
> +      <entry name="display" value="2" summary="The tablet is a display tablet, such as a Cintiq"/>
> +    </enum>
> +
> +    <event name="type">
> +      <description summary="the tablet type">
> +       This event is sent in the initial burst of events before the
> +       wp_tablet.done event.
> +      </description>
> +      <arg name="type" type="uint" summary="the tablet type (internal, external, ...)"/>
> +    </event>

I'm tbh wondering whether this is all that useful. I'm seeing the
fixme in your 01/13 weston patch where this is missing a dependency on
libwacom, and I've got a similar fixme in mutter. The protocol already
exports vid/pid and node file, that seems enough to poke libwacom on
the client side, and it's not like many clients need this to implement
different behavior (the only potential user I see on my side is
gnome-control-center).

I think that's my only nitpick at this stage. Consider this:
Reviewed-by: Carlos Garnacho <carlosg at gnome.org>

And the weston series really, I could see nothing wrong with it, even
helped me spot a couple of bugs in my mutter branch.

Cheers,
  Carlos