[PATCH wayland] protocol: Remove incorrect statement that attach must precede damage

[Derek Foreman]

On 19/11/15 01:02 AM, Jonas Ådahl wrote:
> On Wed, Nov 18, 2015 at 09:44:11AM -0600, Derek Foreman wrote:
>> The documentation for wl_surface.commit makes it clear that the
>> application of damage follows attach during the commit, so it
>> doesn't matter what order the app sends the requests.
>>
>> Many existing apps post damage before attaching a buffer already,
>> and it's really quite reasonable to do so.
>>
>> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> 
> Yes, the documentation of commit seems to kind of contradict what you
> removed here. While it can't hurt to mention that the damage affects
> either the buffer attached within the same commit or the already
> attached buffer, if no new buffer was attached, it is already spelled
> out pretty clearly in wl_surface.commit, so consider this patch
> Reviewed-by: Jonas Ådahl <jadahl at gmail.com>

Thanks.

Pushed.

I might try to clear up the language a bit later, but that'll take a few
iterations and I'd like to get damage_buffer sorted out first (and it
copies all this text).

> 
> 
> Jonas
> 
>> ---
>>  protocol/wayland.xml | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/protocol/wayland.xml b/protocol/wayland.xml
>> index 9c22d45..525e092 100644
>> --- a/protocol/wayland.xml
>> +++ b/protocol/wayland.xml
>> @@ -1095,10 +1095,8 @@
>>        <description summary="mark part of the surface damaged">
>>  	This request is used to describe the regions where the pending
>>  	buffer is different from the current surface contents, and where
>> -	the surface therefore needs to be repainted. The pending buffer
>> -	must be set by wl_surface.attach before sending damage. The
>> -	compositor ignores the parts of the damage that fall outside of
>> -	the surface.
>> +	the surface therefore needs to be repainted. The compositor
>> +	ignores the parts of the damage that fall outside of the surface.
>>  
>>  	Damage is double-buffered state, see wl_surface.commit.
>>  
>> -- 
>> 2.6.2
>>
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel