[PATCH 3/5] socket-test: Fix indentation to follow project code style policy

Marek Chalupa mchqwerty at gmail.com
Mon Nov 23 00:06:21 PST 2015


Hi

On 11/19/2015 08:23 PM, Bill Spitzak wrote:
>
>
> On Thu, Nov 19, 2015 at 1:36 AM, Bryce Harrington <bryce at osg.samsung.com
> <mailto:bryce at osg.samsung.com>> wrote:
>
>     From: Bryce Harrington <bryce at bryceharrington.org
>     <mailto:bryce at bryceharrington.org>>
>
>     Signed-off-by: Bryce Harrington <bryce at osg.samsung.com
>     <mailto:bryce at osg.samsung.com>>
>     ---
>       tests/socket-test.c | 174
>     ++++++++++++++++++++++++++--------------------------
>       1 file changed, 87 insertions(+), 87 deletions(-)
>
>     diff --git a/tests/socket-test.c b/tests/socket-test.c
>     index c53f972..f6db6cf 100644
>     --- a/tests/socket-test.c
>     +++ b/tests/socket-test.c
>     @@ -46,129 +46,129 @@ static const struct sockaddr_un
>     example_sockaddr_un;
>       static const char *
>       require_xdg_runtime_dir(void)
>       {
>     -       char *val = getenv("XDG_RUNTIME_DIR");
>     -       if (!val)
>     -               assert(0 && "set $XDG_RUNTIME_DIR to run this test");
>     +               char *val = getenv("XDG_RUNTIME_DIR");
>     +               if (!val)
>     +                               assert(0 && "set $XDG_RUNTIME_DIR to
>     run this test");
>
>
> How about:
>
>       assert(val && "set $XDG_RUNTIME_DIR to run this test")

Yeah, that looks better IMO.
Actually, we should not need the assert anymore, since we set our own 
XDG_RUNTIME_DIR in test-runner.c (thus it is set always), but better to 
keep it, if anything would change in the future

Cheers,
Marek

>
> ?
>
>
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>


More information about the wayland-devel mailing list