[PATCH weston 08/11] compositor: ignore surface_damage with negative height or width

[Pekka Paalanen]

On Thu, 19 Nov 2015 11:15:38 -0600
Derek Foreman <derekf at osg.samsung.com> wrote:

> On 18/11/15 07:33 PM, Bill Spitzak wrote:
> > 
> > 
> > On Wed, Nov 18, 2015 at 2:32 PM, Derek Foreman <derekf at osg.samsung.com
> > <mailto:derekf at osg.samsung.com>> wrote:
> > 
> >     If we pass negative height or width on to pixman we get error messages
> >     in the log.
> > 
> >     Signed-off-by: Derek Foreman <derekf at osg.samsung.com
> >     <mailto:derekf at osg.samsung.com>>
> >     ---
> >      src/compositor.c | 3 +++
> >      1 file changed, 3 insertions(+)
> > 
> >     diff --git a/src/compositor.c b/src/compositor.c
> >     index 666bc15..0efb325 100644
> >     --- a/src/compositor.c
> >     +++ b/src/compositor.c
> >     @@ -2574,6 +2574,9 @@ surface_damage(struct wl_client *client,
> >      {
> >             struct weston_surface *surface =
> >     wl_resource_get_user_data(resource);
> > 
> >     +       if (width < 0 || height < 0)
> >     +               return;
> > 
> > 
> > Might as well quit on <= 0 here, since a zero-sized rectangle won't do
> > anything.  
> 
> Fair point, I've made the change locally.  When I've accumulated enough
> feedback to make a v2 worthwhile it'll be there.

Yup, you can stamp a
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
on this one with <= 0.

And push for all I care. :-)


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151126/1d91b7cb/attachment.sig>