[PATCH weston 10/11] simple-damage: Offset drawing co-ordinates not buffer start

Derek Foreman derekf at osg.samsung.com
Mon Nov 30 08:06:05 PST 2015


On 27/11/15 04:20 AM, Pekka Paalanen wrote:
> On Wed, 18 Nov 2015 16:32:33 -0600 Derek Foreman
> <derekf at osg.samsung.com> wrote:
> 
>> We've been setting up the viewport by moving the start pointer of
>> the draw buffer, but later when we want to post damage in buffer
>> co-ordinates we'll need to keep track of the x,y offsets anyway.
>> 
>> Signed-off-by: Derek Foreman <derekf at osg.samsung.com> --- 
>> clients/simple-damage.c | 58
>> +++++++++++++++++++++++++++++-------------------- 1 file changed,
>> 34 insertions(+), 24 deletions(-)
> 
> Hi,
> 
> I read this through and checked that you do not change the
> behaviour, except for the debug print.
> 
> I agree with the idea of not playing with the data pointer.
> 
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Thanks, I've pushed this one now.

> Thanks, pq
> 



More information about the wayland-devel mailing list