[PATCH] main: Remove unused function load_backend_new()
Bryce Harrington
bryce at osg.samsung.com
Mon Nov 30 14:25:25 PST 2015
On Mon, Nov 30, 2015 at 02:54:41PM -0600, Derek Foreman wrote:
> On 30/11/15 02:51 PM, Chris Michael wrote:
> > This function is unused throughout the entire weston source tree, so
> > remove it. It seems that the "load_backend" function is the one
> > currently being used
> >
> > Signed-off-by: Chris Michael <cp.michael at samsung.com>
>
> That warning's been bugging me for a while - I think it's for libweston,
> but I'm sure the function can just be added back in with whatever patch
> series actually uses it, so I'm happy to chop it for now.
It seemed like when it was introduced, the first user was just around
the corner, which is why I landed it.
I wonder where we are with this transition? It'd be nice to get more of
the transition out of the way before we get into release mode.
Bryce
> Reviewed-by: Derek Foreman <derekf at osg.samsung.com>
>
> (and pushed)
>
> > ---
> > src/main.c | 17 -----------------
> > 1 file changed, 17 deletions(-)
> >
> > diff --git a/src/main.c b/src/main.c
> > index 292f8e0..6d2216f 100644
> > --- a/src/main.c
> > +++ b/src/main.c
> > @@ -648,23 +648,6 @@ load_backend_old(struct weston_compositor *compositor, const char *backend,
> > return backend_init(compositor, argc, argv, wc, NULL);
> > }
> >
> > -/* Temporary function to be replaced by weston_compositor_load_backend(). */
> > -static int
> > -load_backend_new(struct weston_compositor *compositor, const char *backend,
> > - struct weston_backend_config *config_base)
> > -{
> > - int (*backend_init)(struct weston_compositor *c,
> > - int *argc, char *argv[],
> > - struct weston_config *config,
> > - struct weston_backend_config *config_base);
> > -
> > - backend_init = weston_load_module(backend, "backend_init");
> > - if (!backend_init)
> > - return -1;
> > -
> > - return backend_init(compositor, NULL, NULL, NULL, config_base);
> > -}
> > -
> > static int
> > load_backend(struct weston_compositor *compositor, const char *backend,
> > int *argc, char **argv, struct weston_config *config)
> >
>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
More information about the wayland-devel
mailing list