[PATCH wayland 7/8] client: Remove misplaced documentation about main loop intergration

Pekka Paalanen ppaalanen at gmail.com
Thu Oct 8 04:37:52 PDT 2015


On Mon, 5 Oct 2015 10:41:37 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> On Fri, Oct 02, 2015 at 01:36:20PM -0700, Bryce Harrington wrote:
> > On Fri, Oct 02, 2015 at 05:32:58PM +0800, Jonas Ådahl wrote:
> > > There was documentation about how to integrate the display server file
> > > descriptor in the documentation about wl_display_dispatch_pending().
> > > This is not the right place to put it, and it also had incorrect usage
> > > of the API (calling wl_display_dispatch_queue() on input on an unrelated
> > > fd) as an example.
> > 
> > Rather than just drop the misplaced docs, shouldn't they be moved to a
> > better location?
> 
> I expect it has to be changed/rewritten because there are some
> misleading parts (like call dispatch_queue() on unrelated input). That
> is why I removed it for now, with the plan to add a section about
> external main loop integration elsewhere later.

Yes, it really looks like needing a rewrite, and we have similar better
description at wl_display_prepare_read_queue().

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151008/a7fcbed1/attachment.sig>


More information about the wayland-devel mailing list