[PATCH wayland] scanner: server-side also emit SINCE macros for requests

[Giulio Camuffo]

2015-10-14 4:06 GMT+03:00 Jonas Ådahl <jadahl at gmail.com>:
> On Tue, Oct 13, 2015 at 04:18:19PM -0700, Bryce Harrington wrote:
>> On Fri, Oct 09, 2015 at 10:07:48PM +0200, David FORT wrote:
>> > Server-side we need to know the versions for destructor requests.
>> >
>> > Signed-off-by: David FORT <contact at hardening-consulting.com>
>>
>> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
>>
>> > ---
>> >  src/scanner.c | 1 +
>> >  1 file changed, 1 insertion(+)
>> >
>> > diff --git a/src/scanner.c b/src/scanner.c
>> > index f456aa5..406ba82 100644
>> > --- a/src/scanner.c
>> > +++ b/src/scanner.c
>> > @@ -1266,6 +1266,7 @@ emit_header(struct protocol *protocol, enum side side)
>> >                     emit_structs(&i->request_list, i, side);
>> >                     emit_opcodes(&i->event_list, i);
>> >                     emit_opcode_versions(&i->event_list, i);
>> > +                   emit_opcode_versions(&i->request_list, i);
>
> This will cause compilation error when an event and a request in the
> same interface has the same name. Do we have that restriction already?

That sounds real confusing. If we don't, we should have it, imho.


--
Giulio

>
>
> Jonas
>
>> >                     emit_event_wrappers(&i->event_list, i);
>> >             } else {
>> >                     emit_structs(&i->event_list, i, side);
>> > --
>> > 1.9.1
>> >
>> > _______________________________________________
>> > wayland-devel mailing list
>> > wayland-devel at lists.freedesktop.org
>> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel