[PATCH weston 3/4] compositor-wayland: Properly release input resources when caps change

Pekka Paalanen ppaalanen at gmail.com
Wed Oct 14 01:58:07 PDT 2015


On Fri,  9 Oct 2015 11:28:45 -0500
Derek Foreman <derekf at osg.samsung.com> wrote:

> We should use wl_*_release when available instead of destroy, and we
> should update weston's internal input tracking with weston_seat_releases
> 
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> ---
>  src/compositor-wayland.c | 15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/src/compositor-wayland.c b/src/compositor-wayland.c
> index dbbc1ad..b25f4ea 100644
> --- a/src/compositor-wayland.c
> +++ b/src/compositor-wayland.c

> @@ -1823,6 +1833,7 @@ registry_handle_global(void *data, struct wl_registry *registry, uint32_t name,
>  					 &_wl_fullscreen_shell_interface, 1);
>  	} else if (strcmp(interface, "wl_seat") == 0) {
>  		display_add_seat(b, name, version);
> +		b->seat_version = version;
>  	} else if (strcmp(interface, "wl_output") == 0) {
>  		wayland_backend_register_output(b, name);
>  	} else if (strcmp(interface, "wl_shm") == 0) {

Inconsiquential nit: you assume all wl_seats will be advertised with
the same version. I can't imagine a case where they wouldn't, but...

Otherwise looks fine to me.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20151014/526519a5/attachment.sig>


More information about the wayland-devel mailing list