[PATCH weston] tests: Adding simple waycheck validation tool.

Jon A. Cruz jonc at osg.samsung.com
Fri Oct 16 12:23:47 PDT 2015


On 10/15/2015 01:51 AM, Pekka Paalanen wrote:
> I think it's better to land this stuff in pieces than massage a
> humongous replace-the-world patch series, if we can tell the pieces are
> going in the right direction. The bits here are mostly just following
> the existing weston-test-client-helper.c (which the commit message
> forgot to mention).
>
> But yeah, probably makes sense to see how hooking even this stuff up to
> 'make check' would happen before landing this. That will be one of the
> most interesting things here. This patch as is does not add anything to
> 'make check' which is a little awkward for a series adding new test
> code.
>
> As for writing tests in the mean time, people should just ignore the
> new framework for now, and write tests as if it didn't exist as long as
> it doesn't support what the old framework does.
>
> This way we can incrementally advance on both fronts at the same time.

So, the immediate question would now be as to how I should stage things.
Should the changes that will go into 'make check' be a separate patch
set or should it be an additional patch in this set?

I'd say that running it as a separate set might make juggling git a
little easier on me. But not to a degree to outweigh what would make
reviewing things easier.

-- 
Jon A. Cruz - Senior Open Source Developer
Samsung Open Source Group
jonc at osg.samsung.com


More information about the wayland-devel mailing list