[PATCH v2 0/4] Enum and bitfield XML attributes

Auke Booij auke at tulcod.com
Thu Oct 22 15:13:06 PDT 2015


On 22 October 2015 at 22:51, Nils Chr. Brause <nilschrbrause at gmail.com> wrote:
> Hi,
>
> On Thu, Oct 22, 2015 at 10:18 PM, Bill Spitzak <spitzak at gmail.com> wrote:
>> On Wed, Oct 21, 2015 at 5:22 AM, Nils Chr. Brause <nilschrbrause at gmail.com>
>> wrote:
>>>
>>>
>>> >> - Support for cross-interface enum referencing (e.g.
>>> >> wl_shm_pool::create_buffer::format to wl_shm::format, and
>>> >> wl_surface::set_buffer_transform::transform to wl_output::transform).
>>> >
>>> > Just to be clear on this, I think there is consensus that this should
>>> > be added in a later stage.
>>>
>>> This should be added as soon as possible. Otherwise this is still not very
>>> useful for language bindings. With these missing I would still have to
>>> maintain
>>> my own copy of the wayland.xml for the Wayland C++ Bindigns.
>>
>>
>> Do you have an xml scanner that handles this? I think that is the main
>> reason this is being delayed is that somebody has to figure out how to parse
>> it with xml.
>>
>
> When I first proposed the inclusion of the "enum" and "bitfield"
> attributes to the
> XML file, I had a patch for the C scanner, that used the dot notation everywhere
> to deal with cross references. The scanner for my C++ bindings does the same.
>
> Anyway, from my perspective of a language binding developer, having the
> correct attributes in the XML file is most important and appropriate patches for
> the C scanner can be added later. ;)
>
> I am kinda afraid that these will be forgotten otherwise.
>
> Cheers,
> Nils

Just to be ultra clear on this, when I said "I think there is
consensus that this should be added in a later stage", the emphasis
was on "should", not "in a later stage".

I support the dot notation. It's missing from these patches, partly
because I simply don't have the code yet, and partly because I have
the impression it is easier to get smaller patches submitted than big
contributions.


More information about the wayland-devel mailing list