[PATCH] compositor: Disallow negative geometries in backend output configs

[Jasper St. Pierre]

I'm struggling to understand the motivation for this patch.

krh has always said that you need to think of uint and int as two
entirely separate types -- mixing both in math will likely screw up.
You can see this in other places -- widths are often expressed as
signed ints in the protocol, not unsigned ints.

On Fri, Oct 23, 2015 at 11:53 PM, Giulio Camuffo
<giuliocamuffo at gmail.com> wrote:
> 2015-10-24 1:29 GMT+03:00 Bryce Harrington <bryce at osg.samsung.com>:
>> Signed-off-by: Bryce Harrington <bryce at osg.samsung.com>
>> ---
>>  src/compositor.h | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/compositor.h b/src/compositor.h
>> index 6bb6222..4443c72 100644
>> --- a/src/compositor.h
>> +++ b/src/compositor.h
>> @@ -619,9 +619,9 @@ enum weston_capability {
>>   */
>>  struct weston_backend_output_config {
>>         uint32_t transform;
>> -       int32_t width;
>> -       int32_t height;
>> -       int scale;
>> +       uint32_t width;
>> +       uint32_t height;
>> +       uint32_t scale;
>>  };
>
> Reviewed-by: Giulio Camuffo <giuliocamuffo at gmail.com>
>
>>
>>  /* Configuration struct for a backend.
>> --
>> 1.9.1
>>
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/wayland-devel



-- 
  Jasper