[PATCH v2] protocol: Improve data source notification around DnD progress

Michael Catanzaro mcatanzaro at igalia.com
Fri Oct 30 16:06:43 PDT 2015


On Fri, 2015-10-30 at 21:55 +0100, Carlos Garnacho wrote:
> Changes since v1:
>   - Renamed events to have a common "dnd" namespace.

I don't think this was a great change. The event occurs on drop, and
the previous name described that perfectly, whereas with the new name
it's not very clear how it's different from dnd_finished. Maybe
dnd_drop_performed would be better, if slightly redundant.

> @@ -423,7 +423,9 @@
>  	Indicate that the client can accept the given mime type, or
>  	NULL for not accepted.
>  
> -	Used for feedback during drag-and-drop.
> +	This request mandates the final result of the drag-and-drop
> +	operation. If the end result is that no mimetype is
> accepted,
> +	the drag source will receive drag_source.cancelled.
>        </description>
>  
>        <arg name="serial" type="uint"/>

Nit: "mandates" is not a great choice of word here... how about
"determines" instead?
Reviewed-by: Michael Catanzaro <mcatanzaro at igalia.com>



More information about the wayland-devel mailing list