[PATCH weston] compositor-fbdev: Remove bizarre division by sizeof
Pekka Paalanen
ppaalanen at gmail.com
Thu Sep 10 00:06:36 PDT 2015
On Wed, 9 Sep 2015 16:39:48 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:
> On Wed, Sep 02, 2015 at 01:45:20PM -0500, Derek Foreman wrote:
> > Really not sure why this was even here - it worked because
> > we were dividing by 1.
> >
> > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
>
> > ---
> > src/compositor-fbdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/compositor-fbdev.c b/src/compositor-fbdev.c
> > index a5c7947..81281d0 100644
> > --- a/src/compositor-fbdev.c
> > +++ b/src/compositor-fbdev.c
> > @@ -337,7 +337,7 @@ fbdev_query_screen_info(struct fbdev_output *output, int fd,
> >
> > info->buffer_length = fixinfo.smem_len;
> > info->line_length = fixinfo.line_length;
> > - strncpy(info->id, fixinfo.id, sizeof(info->id) / sizeof(*info->id));
> > + strncpy(info->id, fixinfo.id, sizeof(info->id));
> >
> > info->pixel_format = calculate_pixman_format(&varinfo, &fixinfo);
> > info->refresh_rate = calculate_refresh_rate(&varinfo);
Looks harmless enough for the -rc, so pushed:
3f32a13..6179338 master -> master
Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150910/0ce0bdc7/attachment.sig>
More information about the wayland-devel
mailing list