[PATCH weston] rpi: fix segfault at startup in rpi_flippipe_init() v2

[Pekka Paalanen]

On Wed, 09 Sep 2015 14:18:45 +0100
John Sadler <deathofathousandpapercuts at gmail.com> wrote:

> On 08/09/15 13:31, Pekka Paalanen wrote:
> > From: John Sadler <deathofathousandpapercuts at gmail.com>
> >
> > When running with the RPi backend, Weston now segfaults at startup on the
> > line:
> >
> >     flippipe->clk_id = output->base.compositor->presentation_clock;
> >
> > in `rpi_flippipe_init()`.
> >
> > This is because `output->base.compositor` is NULL. This problem did not
> > exist on 1.8.0, and it looks like it may have been introduced by 954f183e2f.
> >
> > This commit ensures that the `compositor` is initialised in `rpi_backend`
> > and that flippipe init uses the compositor pointer from backend.
> >
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91885
> >
> > Signed-off-by: John Sadler <deathofathousandpapercuts at gmail.com>
> >
> > Changes in v2:
> > - fix summary to not break the build
> > - use output->backend->compositor in rpi_flippipe_init() instead of
> >   output->base.compositor. The latter is set by weston_output_init()
> >   which gets called later than rpi_flippipe_init().
> >
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >
> > ---
> > Hi John,
> >
> > a good find! I adjusted this patch a bit. If you can give a Tested-by
> > for the v2, I can push this.
> 
> Sure. I re-built with your v2 and ran on RPi2. It runs fine, no segfault.
> 
> Tested-by: John Sadler <deathofathousandpapercuts at gmail.com>

Pushed:
   7978bc8..ca510d0  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150910/dc22eb08/attachment.sig>