[PATCH xwayland 1/4] xwayland: Add xwl_touch struct

Carlos Garnacho carlosg at gnome.org
Mon Sep 21 08:57:44 PDT 2015


On Fri, Sep 18, 2015 at 3:06 PM, Olivier Fourdan <ofourdan at redhat.com> wrote:
> Hey Carlos,
> On 27/05/15 18:41, Carlos Garnacho wrote:
>> This struct holds information about each individual, ongoing touchpoint.
>> A list of these is held by the xwl_seat.
>> Signed-off-by: Carlos Garnacho <carlosg at gnome.org>
> lgtm
> Rebased and added this patch to my tree, but I don't have the hardware to
> test.
> Could you please check the tree from here and do some testing:

Tested-by: Carlos Garnacho <carlosg at gnome.org> on all the remaining 3 patches.

Tried on mutter/gnome-shell master and touch on clients works nicely
(tested on xinput test-xi2 and gtk3 apps running with the X11
backend), so does pointer emulation (seen on xev, emacs,...). I've
only found issues when dragging client-side decorated windows (thus
gtk3 forced to run on x11) with touch, windows do wiggle when dragged.
Window dragging on touch triggers the same codepaths than dragging on
non-EWMH compliant WMs do (so based on raw XMoveWindow based on event
root coordinates).

I don't think this bug is intrinsically related to these patches
though, given gtk+ works fine on plain X11, it could also well lie in
mutter's configure request handling or Xwayland surface placement.
I'll investigate nonetheless, but IMO this is too weird and unlikely
to block these patches, which are already a vast improvement for these


More information about the wayland-devel mailing list