[PATCH][weston 1/2] ivi-layout-transition: Change layout_transition_register return type

[Bryce Harrington]

On Mon, Sep 21, 2015 at 11:53:07PM +0000, Tanibata, Nobuhiko (ADITJ/SWG) wrote:
> 
> 
> > -----Original Message-----
> > From: wayland-devel [mailto:wayland-devel-bounces at lists.freedesktop.org] On
> > Behalf Of Bryce Harrington
> > Sent: Tuesday, September 22, 2015 7:31 AM
> > To: Lucas Tanure
> > Cc: wayland-devel at lists.freedesktop.org
> > Subject: Re: [PATCH][weston 1/2] ivi-layout-transition: Change
> > layout_transition_register return type
> > 
> > Hi Lucas,
> > 
> > Thanks for all the IVI patches!  I've only spot checked them but they all look
> > like good solid patches worth landing.  The only reason I've been holding off
> > is because we're literally on the eve of the release, and this week I'm trying
> > to restrain myself just to landing critical bug fixes.  These look rather on
> > the borderline - obviously safe patches that are obviously correct, however it
> > sounds like the issues they fix are like leaks and potential issues rather than
> > problems we would expect users to run into.
> > 
> > But I wanted to doublecheck with you if any of these patches you feel are "must
> > fix" stuff for the release?  Or any you're desperate to see included in 1.9?
> [ntanibata] Hi, these patches are very helpful to fix e.g. memory leak and clean up code. However I think it might not be mandatory to fix them at 1.9 immediately.
> 

Great, thanks Nobuhiko.  Will target them to post-1.9.

Bryce

> Best Regards,
> Nobuhiko Tanibata
> > 
> > Otherwise, I think they're all prime candidates to land immediately post-release,
> > and I can handle getting them in once the release is out the door.
> > 
> > Bryce
> > 
> > On Mon, Sep 21, 2015 at 02:10:32PM -0300, Lucas Tanure wrote:
> > > layout_transition_register could not work and we need to free trans in
> > > the calling function.
> > >
> > > Signed-off-by: Lucas Tanure <tanure at linux.com>
> > > ---
> > >  ivi-shell/ivi-layout-transition.c | 6 ++++--
> > >  1 file changed, 4 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/ivi-shell/ivi-layout-transition.c
> > > b/ivi-shell/ivi-layout-transition.c
> > > index 6370e8f..8d477b4 100644
> > > --- a/ivi-shell/ivi-layout-transition.c
> > > +++ b/ivi-shell/ivi-layout-transition.c
> > > @@ -27,6 +27,7 @@
> > >  #include <assert.h>
> > >  #include <stdlib.h>
> > >  #include <stdio.h>
> > > +#include <stdbool.h>
> > >
> > >  #include "ivi-layout-export.h"
> > >  #include "ivi-layout-private.h"
> > > @@ -181,7 +182,7 @@ ivi_layout_transition_set_create(struct
> > weston_compositor *ec)
> > >  	return transitions;
> > >  }
> > >
> > > -static void
> > > +static bool
> > >  layout_transition_register(struct ivi_layout_transition *trans)  {
> > >  	struct ivi_layout *layout = get_instance(); @@ -190,11 +191,12 @@
> > > layout_transition_register(struct ivi_layout_transition *trans)
> > >  	node = malloc(sizeof(*node));
> > >  	if (node == NULL) {
> > >  		weston_log("%s: memory allocation fails\n", __func__);
> > > -		return;
> > > +		return false;
> > >  	}
> > >
> > >  	node->transition = trans;
> > >  	wl_list_insert(&layout->pending_transition_list, &node->link);
> > > +	return true;
> > >  }
> > >
> > >  static void
> > > --
> > > 2.5.3
> > >
> > > _______________________________________________
> > > wayland-devel mailing list
> > > wayland-devel at lists.freedesktop.org
> > > http://lists.freedesktop.org/mailman/listinfo/wayland-devel
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/wayland-devel