[PATCH wayland] Contributing: explain Patchwork

Pekka Paalanen ppaalanen at gmail.com
Tue Sep 22 00:30:48 PDT 2015

On Tue, 22 Sep 2015 09:22:27 +0300
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> On Mon, 21 Sep 2015 12:31:21 -0700
> Bryce Harrington <bryce at osg.samsung.com> wrote:
> > On Mon, Sep 21, 2015 at 10:41:59AM +0300, Pekka Paalanen wrote:
> > > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > 

> > > +The following patch states are found in Patchwork:
> > > +
> > > +  New
> > > +	Patches under discussion or not yet processed.
> > > +
> > > +  Under review
> > > +	Mostly unused state.
> > 
> > Currently we have a dozen patches marked Under review...
> > 
> > I wonder if we could make better use of this state.
> We have marked, yes. I'm not sure what we gain from it. What could it
> mean? Could it be "someone gave R-b, but needs more reviews to be
> accepted?"
> I think "someone started commenting on this" isn't as useful, or is it?

Or could it perhaps mean "this patch requires of comment from a
specific person", regardless whether that person has started to look at
it yet?

We also have the "delegate" setting, which seems to allow only for
Patchwork Wayland maintainers. Using the delegate for "this particular
person's acceptance is required" seems fitting, no? We can easily add
such people as Pathwork maintainers and there's no reason not to.

In fact, I just added Tanibata-san as Patchwork maintainer, which
allowed me to set the delegate for Emre Ucan's patches to ntanibata.
Tanibata-san's acceptance is required for these patches. I also set the
state to Under review, because I know they are discussing things atm.,
but I'm not sure if it should be New instead. I moved them out of
Deferred, since master is open for development again.

Cc'ing Jonas, since this is tangentially relevant to the protocol dev

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/wayland-devel/attachments/20150922/7d0df06e/attachment.sig>

More information about the wayland-devel mailing list