[PATCH wayland-web] reviewing: Add Reviewed-by reply instructions

Bryce Harrington bryce at osg.samsung.com
Tue Apr 5 22:55:40 UTC 2016


On Tue, Apr 05, 2016 at 12:02:40PM -0500, Yong Bakos wrote:
> From: Yong Bakos <ybakos at humanoriented.com>

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

Pushed:
   8745fe8..4022eeb  master -> master

 
> Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> ---
>  reviewing.html | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/reviewing.html b/reviewing.html
> index a664c50..7f8ce3d 100644
> --- a/reviewing.html
> +++ b/reviewing.html
> @@ -69,8 +69,11 @@ the community. So speak up.
>  <p>
>  Especially, speak up if the patch looks good. If you think it passes the 
>  review criteria, <i>say so</i>. Reply to the email saying "This looks good", "Ship 
> -it!" or "Awesome, thanks!" (BTW, praise goes a long way towards making people 
> -feel welcome).
> +it!" or "Awesome, thanks!" (praise goes a long way towards making people 
> +feel welcome). In addition, add the line <em>Reviewed-by: Real Name
> +<my at email.address></em> so people pushing patches upstream can make it
> +<a title="example reviewed commit message"
> +   href="https://cgit.freedesktop.org/wayland/weston/commit/?id=273874e3c715a7102add0030f200d0a0f17628fa">part of the commit message</a>.
>  </p>
>  
>  <p>
> -- 
> 2.7.2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list