[PATCH weston v2] weston.pc: Properly specify Requires.private

Bryce Harrington bryce at osg.samsung.com
Wed Apr 6 06:39:53 UTC 2016


On Tue, Apr 05, 2016 at 10:11:32AM +0200, Quentin Glidic wrote:
> From: Quentin Glidic <sardemff7+git at sardemff7.net>
> 
> We include wayland-server.h, pixman.h and xkbcommon.h in compositor.h,
> but they are not required for linking if the plugin doesn’t use them.
> 
> Signed-off-by: Quentin Glidic <sardemff7+git at sardemff7.net>

On an initial readup of Requires.private, looks ok:

Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

One thing I wonder is if any of these might need to become a Require
when we are providing a libweston library API?

Bryce
> ---
> 
> v2: Was missing wayland-server
> 
> src/weston.pc.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/weston.pc.in b/src/weston.pc.in
> index 828cb1f..c560eb3 100644
> --- a/src/weston.pc.in
> +++ b/src/weston.pc.in
> @@ -8,4 +8,5 @@ pkglibexecdir=${libexecdir}/@PACKAGE@
>  Name: Weston Plugin API
>  Description: Header files for Weston plugin development
>  Version: @WESTON_VERSION@
> +Requires.private: wayland-server pixman-1 xkbcommon
>  Cflags: -I${includedir}
> -- 
> 2.7.2
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel


More information about the wayland-devel mailing list