[PATCH v5 xdg-shell-unstable-v6] xdg-shell: Add min/max size requests
Jonas Ã…dahl
jadahl at gmail.com
Tue Apr 12 07:22:32 UTC 2016
On Tue, Apr 12, 2016 at 03:20:27AM -0400, Olivier Fourdan wrote:
> Hi Mike,
>
> ----- Original Message -----
> > I think this should probably use uint instead of int for params since zero
> > is the "unset" number. Otherwise you have to write something about negative
> > sizes.
>
> Reason I used "int" is because these are limits for size, which are expressed with int as well. "set_window_geometry" uses "int" and specifies that width and height must be greater than zero.
>
> Similarly, the configure event uses "int" as well, not uint", and also use zero for a special case (zero means the client should decide its own dimension) so it made sense to me to remain consistent by using "int".
>
> But I can switch to uint if everyone agrees.
I think using ints makes most sense. Lets not end up with a salad of
different signedness for the same thing.
Jonas
>
> Cheers,
> Olivier
More information about the wayland-devel
mailing list