[PATCH libinput] udev: update the hwdb matches to avoid use of ( and )

Hans de Goede hdegoede at redhat.com
Wed Apr 13 08:59:18 UTC 2016


Hi,

On 13-04-16 07:06, Peter Hutterer wrote:
> libudev's util_replace_chars() replaces the () with underscores so that match
> would work too but let's use ? instead to make it look like a regex.
>
> This now activates the rules for all cyapa touchpads, before they wouldn't
> have applied to any device.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=93846#c12
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans

> ---
>   udev/90-libinput-model-quirks.hwdb | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/udev/90-libinput-model-quirks.hwdb b/udev/90-libinput-model-quirks.hwdb
> index d5978f7..242c444 100644
> --- a/udev/90-libinput-model-quirks.hwdb
> +++ b/udev/90-libinput-model-quirks.hwdb
> @@ -62,22 +62,22 @@ libinput:name:*ETPS/2 Elantech Touchpad*:dmi:*
>   # The various chromebooks, info from modinfo chromeos_laptop, touchpad names
>   # extrapolated from the chromiumos touchad-tests repo
>   # https://chromium.googlesource.com/chromiumos/platform/touchpad-tests
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*pnFalco:pvr*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*pnFalco:pvr*
>   libinput:name:SynPS/2 Synaptics TouchPad:dmi:*pn*Mario*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*pn*Butterfly*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*pn*Peppy*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*pn*Butterfly*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*pn*Peppy*
>   libinput:name:SynPS/2 Synaptics TouchPad:dmi:*pn*ZGB*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*pn*Parrot*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*bvn*coreboot*:pn*Leon*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*bvn*coreboot*:pn*Falco*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*bvn*coreboot*:pn*Wolf*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*svn*GOOGLE*:pn*Link*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*pn*Parrot*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*bvn*coreboot*:pn*Leon*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*bvn*coreboot*:pn*Falco*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*bvn*coreboot*:pn*Wolf*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*svn*GOOGLE*:pn*Link*
>   libinput:name:SynPS/2 Synaptics TouchPad:dmi:*pn*Alex*
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*svn*SAMSUNG*:pn*Lumpy*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*svn*SAMSUNG*:pn*Lumpy*
>   libinput:name:Atmel maXTouch Touchpad:dmi:*svn*GOOGLE*:pn*Samus*
>    LIBINPUT_MODEL_CHROMEBOOK=1
>
> -libinput:name:Cypress APA Trackpad (cyapa):dmi:*
> +libinput:name:Cypress APA Trackpad ?cyapa?:dmi:*
>    LIBINPUT_MODEL_CYAPA=1
>
>   ##########################################
>


More information about the wayland-devel mailing list