[PATCH wayland-protocols 00/19] Correct writing errors

[Yong Bakos]

On Apr 13, 2016, at 2:54 PM, Bryce Harrington <bryce at osg.samsung.com> wrote:
> 
> On Mon, Apr 11, 2016 at 05:22:47PM -0500, Yong Bakos wrote:
>> From: Yong Bakos <ybakos at humanoriented.com>
>> 
>> This v1 patchset consists of spelling, grammar and minor formatting
>> changes to all protocol xml files. The approach here is to be
>> minimally invasive and to not impart stylistic changes; only corrections
>> and consistency changes have been made, with the motivation of accuracy and
>> clarity of documentation.
>> 
>> Note: Only #16 affects a protocol (fullscreen-shell) directly, by correcting
>>      a parameter name.
>> 
>> Any changes on the grounds of 'consistency' were made to reflect either:
>> 
>> a) the majority of the content in the specific xml doc itself
>> b) the current convention followed by protocol writers, including
>>   wayland.xml
>> 
>> In other words, I hope you will find them non-opinionated. Apologies for
>> the rather verbose patchset, but this should allow easier decision making
>> and hopefully merging. Thanks for reviewing!
>> 
>> yong
>> 
>> 
>> 
>> Yong Bakos (19):
>>  readme: Correct spelling and grammar
>>  presentation-time: Correct minor grammar errors
>>  xdg-shell: Downcase summary values consistently
>>  xdg-shell: Remove inconsistent spacing
>>  xdg-shell: Adjust articles and correct grammar
>>  text-input: Fix indentation and paragraph whitespace
>>  text-input: Rename text-input to text_input
>>  text-input: Correct grammar
>>  tablet: Adjust vertical whitespace for consistency
>>  tablet: Correct grammar and punctuation
>>  relative-pointer: Correct spelling error, one capitalization, and
>>    minor space
>>  pointer-gestures: Correct pluralization, one space, minor vertical
>>    whitespace
>>  pointer-constraints: Correct spelling, grammar and consistency
>>  linux-dmabuf: Add missing articles and punctuation, adjust minor
>>    whitespace
>>  input-method: Correct grammar, add missing line break
>>  fullscreen-shell: Correct spelling of parameter name
>>  fullscreen-shell: Correct grammar, punctuation, minor naming and space
>>  pointer-gestures: Add missing xml declaration
>>  fullscreen-shell: Add missing xml declaration
> 
> Hi Yong,
> 
> Patches 1-2, 9-15, and 17-19 all R-b'd by me.  All are obviously correct
> copyediting to documentation, and I'll land them directly.

Thank you!


> Since patch #16 affects protocol I've opted to omit it from speedy
> landing.  But the spelling fix is correct so +1 from me.

I cc'd Jason E so hopefully he'll chime in.


> The xdg-shell and text-input patches I've left out just because there
> are new versions for each of those protocols in the works, and I'm
> hesistant on introducing a delta that could potentially cause problems.
> 
> For xdg-shell, its v6 is being developed in a branch:
> 
>  https://cgit.freedesktop.org/wayland/wayland-protocols/

Crap, I totally overlooked that branch and was working from master/HEAD.
I'll review again after Olivier's v6 patch is merged.


> For text-input, it doesn't have a branch, but the most recent rev of its
> v2 update is:
> 
>  https://patchwork.freedesktop.org/patch/79435/
> 
> As I understand it, new major versions of protocols will be
> co-installable, so presumably copyedits to the earlier versions of the
> protocols won't cause merge conflicts or anything, so maybe these are
> safe to land?  However, maybe there might be some benefit during the
> final stages of development if diffs between the two protocols aren't
> cluttered up with copyedits?  In any case, it probably makes sense to
> copyedit the new versions of the protocols so we don't inadvertantly
> regress the fixes when moving to the new versions.
> 
> So, first make sure to give review on text-input-v2 and xdg-shell-v6.
> Second, I guess we should decide if copyedits to the older versions of
> the protocols are worth doing, and if so should they be landed
> separately from the new protocols or be included with them?

I see what you're saying and thought about timing as well. My conclusion
was, "well, they're still unstable so ad hoc should be ok," but I do
understand your point.

yong


> 
> 
>> README                                             | 14 ++--
>> stable/presentation-time/presentation-time.xml     |  6 +-
>> .../fullscreen-shell-unstable-v1.xml               | 19 +++--
>> unstable/input-method/input-method-unstable-v1.xml | 40 ++++++-----
>> unstable/linux-dmabuf/linux-dmabuf-unstable-v1.xml | 18 +++--
>> .../pointer-constraints-unstable-v1.xml            | 16 ++---
>> .../pointer-gestures-unstable-v1.xml               |  9 ++-
>> .../relative-pointer-unstable-v1.xml               |  8 +--
>> unstable/tablet/tablet-unstable-v1.xml             | 28 ++++----
>> unstable/text-input/text-input-unstable-v1.xml     | 82 +++++++++++-----------
>> unstable/xdg-shell/xdg-shell-unstable-v5.xml       | 30 ++++----
>> 11 files changed, 142 insertions(+), 128 deletions(-)
>> 
>> --
>> 2.7.2
>> 
>> _______________________________________________
>> wayland-devel mailing list
>> wayland-devel at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/wayland-devel