[PATCH libinput] touchpad: enlarge top button area by a factor 3 instead of 1.5

Hans de Goede hdegoede at redhat.com
Thu Apr 14 09:10:26 UTC 2016


Hi,

On 14-04-16 02:43, Peter Hutterer wrote:
> From: Peter Frühberger <peter.fruehberger at gmail.com>
>
> When the touchpad is disabled, the top software button on the Lenovo T440
> series touchpads currently enlarge by a factor of 1.5 (to 15mm). This is not
> enough, a user has to rotate the wrist quite uncomfortable when using
> the left mouse button.
>
> When the touchpad itself is off anyway we can extend the size of the top
> software buttons to the factor 3, i.e. 30mm.
>
> Signed-off-by: Peter Frühberger <peter.fruehberger at gmail.com>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


> ---
>   src/evdev-mt-touchpad.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/evdev-mt-touchpad.c b/src/evdev-mt-touchpad.c
> index 0640974..6c8ab37 100644
> --- a/src/evdev-mt-touchpad.c
> +++ b/src/evdev-mt-touchpad.c
> @@ -1156,7 +1156,7 @@ tp_suspend(struct tp_dispatch *tp, struct evdev_device *device)
>   	if (tp->buttons.has_topbuttons) {
>   		evdev_notify_suspended_device(device);
>   		/* Enlarge topbutton area while suspended */
> -		tp_init_top_softbuttons(tp, device, 1.5);
> +		tp_init_top_softbuttons(tp, device, 3.0);
>   	} else {
>   		evdev_device_suspend(device);
>   	}
>


More information about the wayland-devel mailing list