[PATCH wayland-protocols 2/7] xdg-shell: Put xdg_shell events after requests

Yong Bakos junk at humanoriented.com
Thu Apr 14 13:50:32 UTC 2016


On Apr 14, 2016, at 3:28 AM, Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> It makes the structure consistent with most other protocols and
> provides a clear separation between what is done by the server and what
> is done by the client.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>

Looks good to me.

Reviewed-by: Yong Bakos <ybakos at humanoriented.com>


> ---
> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index c04ab37..f8875e8 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -65,6 +65,14 @@
>      <arg name="surface" type="object" interface="wl_surface"/>
>    </request>
> 
> +    <request name="pong">
> +      <description summary="respond to a ping event">
> +	A client must respond to a ping event with a pong request or
> +	the client may be deemed unresponsive.
> +      </description>
> +      <arg name="serial" type="uint" summary="serial of the ping event"/>
> +    </request>
> +
>    <event name="ping">
>      <description summary="check if the client is alive">
> 	The ping event asks the client if it's still alive. Pass the
> @@ -81,14 +89,6 @@
>      </description>
>      <arg name="serial" type="uint" summary="pass this to the pong request"/>
>    </event>
> -
> -    <request name="pong">
> -      <description summary="respond to a ping event">
> -	A client must respond to a ping event with a pong request or
> -	the client may be deemed unresponsive.
> -      </description>
> -      <arg name="serial" type="uint" summary="serial of the ping event"/>
> -    </request>
>  </interface>
> 
>  <interface name="zxdg_surface_v6" version="1">
> -- 
> 2.4.3
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel




More information about the wayland-devel mailing list