[PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

Pekka Paalanen ppaalanen at gmail.com
Thu Apr 14 14:05:56 UTC 2016


On Mon, 11 Apr 2016 17:30:21 -0500
Yong Bakos <junk at humanoriented.com> wrote:

> Jason,
> See below, this one patch affects the argument name of the
> zwp_fullscreen_shell_v1#capability event param name.
> 
> yong
> 
> 
> > On Apr 11, 2016, at 5:23 PM, Yong Bakos <junk at humanoriented.com> wrote:
> > 
> > From: Yong Bakos <ybakos at humanoriented.com>
> > 
> > Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> > ---
> > unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml b/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
> > index 93f95b8..b32dd88 100644
> > --- a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
> > +++ b/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
> > @@ -85,7 +85,7 @@
> > 	wl_display.sync request immediately after binding to ensure that they
> > 	receive all the capability events.
> >       </description>
> > -      <arg name="capabilty" type="uint"/>
> > +      <arg name="capability" type="uint"/>
> >     </event>
> > 
> >     <enum name="present_method">

Hi,

for C language bindings, I cannot see argument names making any
difference. We should usually refrain from changing them, but in this
case it is such an obvious typo that I'm ok with changing it. So have a
Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

The fun question is, do any other language bindings actually care about
the names as API?

This is yet another undocumented conundrum about the Wayland XML
language.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160414/d2577beb/attachment-0001.sig>


More information about the wayland-devel mailing list