[PATCH wayland-protocols 4/7] xdg-shell: Improve error enum formatting some

Yong Bakos junk at humanoriented.com
Thu Apr 14 14:34:52 UTC 2016


On Apr 14, 2016, at 3:28 AM, Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> The long lines stood out, break them by putting the summary on its own
> line.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>

Looks good to me.

Reviewed-by: Yong Bakos <ybakos at humanoriented.com>

yong


> ---
> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index 2a3cf66..ea4f675 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -37,10 +37,14 @@
> 
>     <enum name="error">
>       <entry name="role" value="0" summary="given wl_surface has another role"/>
> -      <entry name="defunct_surfaces" value="1" summary="xdg_shell was destroyed before children"/>
> -      <entry name="not_the_topmost_popup" value="2" summary="the client tried to map or destroy a non-topmost popup"/>
> -      <entry name="invalid_popup_parent" value="3" summary="the client specified an invalid popup parent surface"/>
> -      <entry name="invalid_surface_state" value="4" summary="the client provided an invalid surface state"/>
> +      <entry name="defunct_surfaces" value="1"
> +	     summary="xdg_shell was destroyed before children"/>
> +      <entry name="not_the_topmost_popup" value="2"
> +	     summary="the client tried to map or destroy a non-topmost popup"/>
> +      <entry name="invalid_popup_parent" value="3"
> +	     summary="the client specified an invalid popup parent surface"/>
> +      <entry name="invalid_surface_state" value="4"
> +	     summary="the client provided an invalid surface state"/>
>     </enum>
> 
>     <request name="destroy" type="destructor">
> -- 
> 2.4.3
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list