[PATCH weston v5 03/11] drm: port the drm backend to the new init api
Bryce Harrington
bryce at osg.samsung.com
Fri Apr 15 22:02:33 UTC 2016
On Fri, Apr 15, 2016 at 02:32:04PM +0200, Benoit Gschwind wrote:
> > + /** The seat to be used by the output. Set to NULL to use the
> > + * default seat. */
> > + char *seat;
> > + /** The modeline to be used by the output. Refer to the documentation
> > + * of WESTON_DRM_BACKEND_OUTPUT_PREFERRED for details. */
> > + char *modeline;
>
> Maybe enum with drmModeModeInfo* is better API than free string API?
I think you're probably right that weston_drm_backend_output_config
could hold a pointer to the enum rather than the string. I've moved
weston_drm_backend_output_config to be a private struct in
compositor-drm.c so this should be doable.
But I think I'm going to opt to leave this change to Giulio as follow-up
work, as I think it needs deeper thought than I'm going to be able to
give it in this patchset. There was also some discussion about whether
WESTON_DRM_BACKEND_OUTPUT_PREFERRED should be renamed, in which case it
would make sense to do the change in conjunction with that.
Bryce
More information about the wayland-devel
mailing list