[PATCH weston v5 00/11] drm: port the drm backend to the new init api

[Bryce Harrington]

On Fri, Apr 15, 2016 at 03:17:15PM +0200, Benoit Gschwind wrote:
> Hello Bryce,
> 
> The patches set was tested above [1]
> 
> I tested drm-bakcend and x11-backend successfully with the full patchset.
> 
> Here are the resume of my comments and review. I send separate e-mail
> when contextual comments are required.

Thanks for reviewing it, Benoit!

Unfortunately I forgot to include your R-b's but I'm pretty certain
there will be a v7 of this set, and will include them there.  Still,
due to how extensive the v6 changes were, another re-review would be
worth the effort.

Bryce
 
> PATCH 01/11:
> 
> Do what is expected.
> 
> Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>
> 
> PATCH 02/11:
> 
> Do what is expected.
> 
> Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>
> 
> PATCH 03/11
> 
> Already commented in another e-mail
> 
> PATCH 04/11
> 
> Do what is expected.
> 
> Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>
> 
> PATCH 05/11
> 
> Do what is expected.
> 
> Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>
> 
> PATCH 06/11
> 
> Agree with Pekka comments, I'm available to fix issues if needed.
> 
> PATCH 07/11
> 
> Agree with Pekka comments, I'm available to fix issues if needed.
> 
> PATCH 08/11
> 
> The re-factor look functional. Other decision tie to the community :)
> 
> PATCH 09/11
> 
> This patch look to address some concern I raised in the patch 03/11, but
> seems to need more discussion.
> 
> PATCH 10/11
> 
> The patch look to address issue of PATCH 07/11 that Pekka raised about
> freeing config variable.
> 
> PATCH 11/11
> 
> Look fine.
> 
> Reviewed-by: Benoit Gschwind <gschwind at gnu-log.net>
> 
> 
> 
> [1] git node: 94cb06a208130b0ee16553a2cd513e5e7d67f368
> 
> 
> 
> Le 13/04/2016 12:25, Bryce Harrington a écrit :
> > In following up on my earlier update of Giulio's drm backend config
> > patch, I've taken the liberty to try and also integrate a couple of
> > Benoit's other backend configuration patches into this patchset.
> > 
> > Giulio and Benoit took different approaches in their implementations.
> > I've attempted to reconcile them so that they are stylistically
> > consistent, along with incorporating pq's request to have the root
> > config structure incorporate versioning information.  I went through all
> > the review comments against each of the backend config patches and
> > incorporated the suggestions people made.  The resultant changes have
> > ended up a bit more extensive than I had expected, and I apologize for
> > any toe stepping I'm doing but my hope is to move the collective work
> > closer to being landable.
> > 
> > ---
> > todo:
> >   - Use backend-specific header #defines for struct_version values
> > v5:
> >   - Add missing compositor-drm.h
> >   - Integrate wayland, x11, and headless backend patches
> >   - Implement struct versioning for wayland, x11, and headless backend
> >     patches in the weston_backend_config structure, as requested by pq
> >   - Drop bzero usage as suggested in review by Jan Engelhardt
> >   - Don't change 'backend_init' entry point function name, as suggested
> >     in review by Giulio
> >   - Prefer use of load_backend_new() for actual module loading, as
> >     suggested in Giulio's review of the x11 backend patch
> >   - Refactor all backend initialization code paths and code style for
> >   	consistency.
> >   - Squashed drm config struct versioning with drm patch; remainder moved
> >   	to a prerequisite patch.
> > v4:
> >   - Update to current trunk
> >   - Add missing param doc for mode in drm_output_choose_initial_mode
> >   - Rebase to account for code changes by 91880f1e to make vt
> >     switching configurable.
> > 
> > 
> > 
> > Benoit Gschwind (1):
> >   x11: port the x11 backend to the new init api
> > 
> > Bryce Harrington (9):
> >   Revert "main: Remove unused function load_backend_new()"
> >   compositor: Version the backend configuration structures
> >   drm: Fix gcc warning about missing braces.
> >   compositor: Document refs for alternatives/assumptions for backend
> >     configs
> >   headless: port the headless backend to the new init api
> >   drm: Code and comments reformatting for consistency with other backend
> >     configs
> >   drm: Don't hang onto the backend config object post-backend_init
> >   Enforce destruction of all backend config objects after initialization
> >   drm: Drop use of drm_config config wrapper
> > 
> > Giulio Camuffo (1):
> >   drm: port the drm backend to the new init api
> > 
> >  Makefile.am               |   5 +
> >  src/compositor-drm.c      | 216 ++++++++++++++------------------
> >  src/compositor-drm.h      | 125 +++++++++++++++++++
> >  src/compositor-headless.c |  69 +++++------
> >  src/compositor-headless.h |  51 ++++++++
> >  src/compositor-x11.c      | 157 ++++++++----------------
> >  src/compositor-x11.h      |  60 +++++++++
> >  src/compositor.h          |  24 +++-
> >  src/main.c                | 304 +++++++++++++++++++++++++++++++++++++++++++++-
> >  9 files changed, 734 insertions(+), 277 deletions(-)
> >  create mode 100644 src/compositor-drm.h
> >  create mode 100644 src/compositor-headless.h
> >  create mode 100644 src/compositor-x11.h
> >