[PATCH v3] protocol: Extend wl_touch with touchpoint shape and orientation

[Pekka Paalanen]

On Tue, 19 Apr 2016 08:28:10 -0500
Yong Bakos <junk at humanoriented.com> wrote:

> On Apr 18, 2016, at 11:49 PM, Peter Hutterer <peter.hutterer at who-t.net> wrote:
> > On Mon, Apr 18, 2016 at 12:36:39PM +0800, Jonas Ådahl wrote:  
> >> On Fri, Apr 15, 2016 at 08:01:35AM -0700, Dennis Kempin wrote:  
> >>> This CL updates the wl_touch interface with a shape and
> >>> orientation event.
> >>> The shape/orientation of a touch point is not relevant for most UI
> >>> applications, but allows a better experience in some cases
> >>> such as drawing apps.
> >>> 
> >>> The events are used by the compositor to inform the client
> >>> about changes in the shape and orientation of a touchpoint, which is
> >>> approximated by an ellipse and it's angle to the y-axis.
> >>> 
> >>> The event is optional and only sent when compositor and the
> >>> touch device support this type of information. The client is
> >>> responsible for making a reasonable assumption about the
> >>> touch shape if no shape is reported.
> >>> 
> >>> Signed-off-by: Dennis Kempin <denniskempin at google.com>
> >>> ---
> >>> protocol/wayland.xml | 64 ++++++++++++++++++++++++++++++++++++++++++++++++----
> >>> 1 file changed, 59 insertions(+), 5 deletions(-)

> >>> + Both are specified in surface coordinates. The center of the ellipse is
> >>> + always at the touchpoint location as reported by wl_touch.down or
> >>> + wl_touch.move.
> >>> +
> >>> + This event is only sent by the compositor if the touch device supports shape
> >>> + reports. The client has to make reasonable assumptions about the shape if
> >>> + it did not receive this event.
> >>> +      </description>
> >>> +      <arg name="id" type="int" summary="the unique ID of this touch point"/>
> >>> +      <arg name="major" type="fixed" summary="length of the major
> >>> axis in surface local coordinates"/>
> >>> +      <arg name="minor" type="fixed" summary="length of the minor
> >>> axis in surface local coordinates"/>  
> > 
> > don't you need a dash here: surface-local? or is that american vs british
> > english?  
> 
> While I agree, since this is a compound adjective, the convention so far in all
> other protocol docs has been just "surface local" without the dash. That said,
> there are some description paragraphs that do use "surface-local."
> 
> Please tell me to resist the temptation to send patches that would standardize
> this to the more correct "surface-local" everywhere. :)

If someone can tell us why it should be one way or another, go wild. ;-)

I have no idea which way it should have been.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160419/db9bb5ba/attachment-0001.sig>