[PATCH wayland-protocols v2 0/5] Stabilize wl_scaler as wp_viewporter

[Daniel Stone]

Hi,

On 19 April 2016 at 15:46, Yong Bakos <junk at humanoriented.com> wrote:
> On Apr 19, 2016, at 7:23 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
>> The final XML file is also verbatim at the end of this email to allow easy
>> overall review.

Thanks a lot for this, that helps hugely.

> v2 patches 1 - 4 look good and are
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
>
> I defer to Daniel/others regarding 5/5.

Below nitpicks notwithstanding:
Reviewed-by: Daniel Stone <daniels at collabora.com>

>> <?xml version="1.0" encoding="UTF-8"?>
>> <protocol name="viewporter">
>>
>>  <copyright>
>>    Copyright © 2013-2014 Collabora, Ltd.

-2016

>>  <interface name="wp_viewporter" version="1">
>>    <description summary="surface cropping and scaling">
>>      The global interface exposing surface cropping and scaling
>>      capabilities is used to instantiate an interface extension for a

'interface extension'? Is that meant to be instance extension, or is
it meaning an interface which extends the wl_surface? No problem
either way.

>>  <interface name="wp_viewport" version="1">
>>    <description summary="crop and scale interface to a wl_surface">
>>      An additional interface to a wl_surface object, which allows the
>>      client to specify the cropping and scaling of the surface
>>      contents.
>>
>>      This interface works with two concepts: the source rectangle (src_x,
>>      src_y, src_width, src_height), and the destination size (dst_width,
>>      dst_height). The contents of the source rectangle are scaled to the
>>      destination size, and content outside the source rectangle is culled.

s/culled/ignored/ as culled implies a destructive operation. I know
there's no way anyone particularly familiar with how Wayland works
could read it to be destructive to the wl_buffer content, but might as
well make it as accessible as possible. :)

>>      The x, y arguments of wl_surface.attach are applied as normal to
>>      the surface. They indicate how many pixels to remove from the
>>      surface size from the left and the top. In other words, they are
>>      still in the surface-local coordinate system, just like dst_width
>>      and dst_height are.

In a similar spirit, s/pixels to remove from the surface size/pixels
to translate the surface position by/.

Cheers,
Daniel