[PATCH] xdg-shell: add invalid min/max size errors

[Yong Bakos]

On Apr 20, 2016, at 4:13 AM, Olivier Fourdan <ofourdan at redhat.com> wrote:
> 
> Given that set_min_size and set_max_size requests can raise protocol
> errors, add the errors that will be raised.
> 
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>

These error types seem to help resolve the issues discussed, regarding
invalid min/max size requests, and is

Reviewed-by Yong Bakos <ybakos at humanoriented.com>

yong


> ---
> unstable/xdg-shell/xdg-shell-unstable-v6.xml | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/unstable/xdg-shell/xdg-shell-unstable-v6.xml b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> index ce57153..48cdae9 100644
> --- a/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> +++ b/unstable/xdg-shell/xdg-shell-unstable-v6.xml
> @@ -40,6 +40,8 @@
>       <entry name="defunct_surfaces" value="1" summary="xdg_shell was destroyed before children"/>
>       <entry name="not_the_topmost_popup" value="2" summary="the client tried to map or destroy a non-topmost popup"/>
>       <entry name="invalid_popup_parent" value="3" summary="the client specified an invalid popup parent surface"/>
> +      <entry name="invalid_min_size" value="4" summary="the client specified an invalid minimum size"/>
> +      <entry name="invalid_max_size" value="5" summary="the client specified an invalid maximum size"/>
>     </enum>
> 
>     <request name="destroy" type="destructor">
> @@ -470,11 +472,12 @@
> 	request.
> 
> 	Requesting a maximum size to be smaller than the minimum size of
> -	a surface is illegal and will result in a protocol error.
> +	a surface is illegal and will result in a protocol error
> +	"invalid_max_size".
> 
> 	The width and height must be greater than or equal to zero. Using
> 	strictly negative values for width and height will result in a
> -	protocol error.
> +	protocol error "invalid_max_size".
>       </description>
>       <arg name="width" type="int"/>
>       <arg name="height" type="int"/>
> @@ -511,11 +514,12 @@
> 	request.
> 
> 	Requesting a minimum size to be larger than the maximum size of
> -	a surface is illegal and will result in a protocol error.
> +	a surface is illegal and will result in a protocol error
> +	"invalid_min_size".
> 
> 	The width and height must be greater than or equal to zero. Using
> 	strictly negative values for width and height will result in a
> -	protocol error.
> +	protocol error "invalid_min_size".
>       </description>
>       <arg name="width" type="int"/>
>       <arg name="height" type="int"/>
> -- 
> 2.5.5
> 
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel