[PATCH weston 3/4] data-device: Update current action even if source version is old

Carlos Garnacho carlosg at gnome.org
Thu Apr 21 16:14:52 UTC 2016


Hi!,

On Thu, Apr 21, 2016 at 5:09 AM, Jonas Ã…dahl <jadahl at gmail.com> wrote:
> If the version of the source object is old enough to not have
> wl_data_source.set_actions() the current action would never be updated
> since source->set_actions would never be set.
>
> To fix this, instead of checking whether source->set_actions before
> proceeding with updating the current action, just always update the
> action when we know all parts are valid dnd data device objects.

Totally makes sense.

Reviewed-by: Carlos Garnacho <carlosg at gnome.org>

Cheers,
  Carlos


More information about the wayland-devel mailing list