[PATCH wayland-protocols 16/19] fullscreen-shell: Correct spelling of parameter name

Bryce Harrington bryce at osg.samsung.com
Thu Apr 21 21:36:09 UTC 2016


On Thu, Apr 14, 2016 at 05:05:56PM +0300, Pekka Paalanen wrote:
> On Mon, 11 Apr 2016 17:30:21 -0500
> Yong Bakos <junk at humanoriented.com> wrote:
> 
> > Jason,
> > See below, this one patch affects the argument name of the
> > zwp_fullscreen_shell_v1#capability event param name.
> > 
> > yong
> > 
> > 
> > > On Apr 11, 2016, at 5:23 PM, Yong Bakos <junk at humanoriented.com> wrote:
> > > 
> > > From: Yong Bakos <ybakos at humanoriented.com>
> > > 
> > > Signed-off-by: Yong Bakos <ybakos at humanoriented.com>
> > > ---
> > > unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml b/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
> > > index 93f95b8..b32dd88 100644
> > > --- a/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
> > > +++ b/unstable/fullscreen-shell/fullscreen-shell-unstable-v1.xml
> > > @@ -85,7 +85,7 @@
> > > 	wl_display.sync request immediately after binding to ensure that they
> > > 	receive all the capability events.
> > >       </description>
> > > -      <arg name="capabilty" type="uint"/>
> > > +      <arg name="capability" type="uint"/>
> > >     </event>
> > > 
> > >     <enum name="present_method">
> 
> Hi,
> 
> for C language bindings, I cannot see argument names making any
> difference. We should usually refrain from changing them, but in this
> case it is such an obvious typo that I'm ok with changing it. So have a
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Alright, pushed:

   a8d7dce..5eb2a8d  master -> master

Bryce
 
> The fun question is, do any other language bindings actually care about
> the names as API?
> 
> This is yet another undocumented conundrum about the Wayland XML
> language.
> 
> 
> Thanks,
> pq

> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
> 
> iQIVAwUBVw+jxCNf5bQRqqqnAQgedw/+IuZkKUp2MYgYAOx22yKDkq5hGwtkfzLo
> YTDd1WRWXQ7w5OgXVD3YOA01QpLnFcjetpVvXn0IU3j5qStJ6P2P2e15+5L+c6N4
> siNiEEo5k1lc04R+1pmxMC8ud6LgX34OMkhf7/al4A5wYNdEMeikgiQ8nKQWsMzc
> 1nJVbkd0Ln5MtuBQpOWCmz/Js5T4RibwmcTnubMCV9rKZkjrX9/+qDjGAAjW+3GW
> yPX+9AuBTJcNPrFbY7WmlC76WbAyh9cSapzUUdW9E784+sT0VHBWGGeyE/y1q9yt
> duMdkSknAoWo4R+bnr/pZcwKPdjEaVyA838/FBCerMCAb2mlMKw9arIyvMhi5LeO
> U3BhiCH3Jr3KFXObyar7+RTcq7OAVeTWVf8U2G2bWzuP6ItfV72ONoFx1gK1U740
> c7YK+8m8Tw9to6KLDD4eT4R7NtCiJSSn/V0RpHK/BNzMcFB61WMivYCAlDy2TQ54
> P/ZBLmyAPbdLDbEs4RBYvAFAj8V2t9KqVcQ8pxpuAZQiCCjJCx5P7wwHsXlo5K28
> f9R2F5/pCPWu//Q9e/08xKyU57hWNOCX3uVbA1/o6rXtdVnzGq2fmmZstc23CrGh
> eSORgSbrm4OYEhU7beAWkVv6X28JOSP4eD0bs1R70bLvFTedGS5x4N6y5LCxzePk
> wgaVugZWS4w=
> =UlFn
> -----END PGP SIGNATURE-----


> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel



More information about the wayland-devel mailing list