[PATCH v2 wayland-protocols] Add pad support to the tablet protocol

[Peter Hutterer]

On Thu, Apr 21, 2016 at 11:55:49AM -0700, Bryce Harrington wrote:
> On Tue, Apr 19, 2016 at 03:00:38PM +1000, Peter Hutterer wrote:
> > From: Carlos Garnacho <carlosg at gnome.org>
> > 
> > The pad's interface is similar to the tool interface, a client is notified of
> > the pad after the tablet_added event.
> > 
> > The pad has three functionalities: buttons, rings and strips.
> > Buttons are fairly straightforward, rings and strips are separate interfaces
> > with a pointer-axis-like source/value/frame events.
> > The two interfaces are effectively identical but for the actual value they
> > send (degrees vs normalized position).
> > 
> > Specific to the pad device is the set_feedback request which enables a client
> > to set a user-defined string to display for an OSD on the current mappings.
> > This request is available for buttons, rings and strips.
> > 
> > Finally, the pad supports "modes", effectively sets of button/ring/strip
> > configurations.
> > 
> > Signed-off-by: Carlos Garnacho <carlosg at gnome.org>
> > Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> 
> Looks pretty good.  A few grammar suggestions below.  With those fixed,
> 
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>

[...]

> > +	information to offer visual feedback about the button layout
> > +	(eg. on-screen displays).
> > +
> > +	The string offered is considered user visible; general
> > +	internationalization rules apply.
> 
> This string is described both here and in the first sentence.  It might
> be better to move the "UTF-8 encoded string" definition out of the first
> sentence and put it here.  Should probably also reference the string by
> its name to be totally clear; i.e. something like,
> 
> The provided string 'description' is an UTF-8 encoded string to be
> associated with this ring, and is considered user visible; general
> internationalization rules apply.

applied as-is, thanks.

> Also that last bit about internationalization seems like it could be
> stronger; I'm not entirely sure what you are pointing out here; are you
> just indicating that the string might be in a language other than
> English and/or need translation applied to it?  Perhaps a pointer to a
> reference would help here.
> 
> Also, this makes me wonder if we do need to call out the
> internationalization rules for this string, are there other strings in
> our protocols that should be similarly flagged?  If so, we might want to
> have a standard reference to point to; if not, then maybe it's not
> important to flag it here?

the string is user-visible in that if the compositor shows an OSD of the
tablet, the string associated will be shown next to the strip. For example
if a button is mapped to "open", the OSD should show Abrir in the spanish
locale, etc. Same for strip and rings. I don't quite know how to put that in
protocol-sounding words though :)

all others fixed as requested.

Cheers,
   Peter