[PATCH 3/5] rdp: fix presentation for the RDP compositor

Pekka Paalanen ppaalanen at gmail.com
Fri Apr 22 13:55:13 UTC 2016


On Fri, 22 Apr 2016 15:19:04 +0200
David Fort <rdp.effort at gmail.com> wrote:

> Set an update delay that is a multiple of the output frequency, or we may do
> incorrect weston_output_finish_frame calls.
> ---
>  src/compositor-rdp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c
> index 9274674..4cbc1c3 100644
> --- a/src/compositor-rdp.c
> +++ b/src/compositor-rdp.c
> @@ -378,7 +378,7 @@ rdp_output_repaint(struct weston_output *output_base, pixman_region32_t *damage)
>  	pixman_region32_subtract(&ec->primary_plane.damage,
>  				 &ec->primary_plane.damage, damage);
>  
> -	wl_event_source_timer_update(output->finish_frame_timer, 16);
> +	wl_event_source_timer_update(output->finish_frame_timer, 10);
>  	return 0;
>  }
>  

Hi,

I'm worried that there are more things wrong. This does not look like a
fix, it just improves the odds of not failing if any.

So, you have a 100 Hz output update frequency on RDP?

What actually determines the frequency if not exactly the timer you
change here?

In any case, patches 1-4 are:
Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160422/b5a00f59/attachment.sig>


More information about the wayland-devel mailing list