[PATCH weston] linux-dmabuf: Keep checking planes even if the first doesn't support lseek

Derek Foreman derekf at osg.samsung.com
Mon Apr 25 14:23:24 UTC 2016


If we break; when lseek fails we can fail to do some legitimate tests
on remaining planes in a multi-plane buffer.

Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
---
 src/linux-dmabuf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/linux-dmabuf.c b/src/linux-dmabuf.c
index 8c6337c..78e77a2 100644
--- a/src/linux-dmabuf.c
+++ b/src/linux-dmabuf.c
@@ -219,7 +219,7 @@ params_create(struct wl_client *client,
 		 * by the kernel not supporting seeking on dmabuf */
 		size = lseek(buffer->attributes.fd[i], 0, SEEK_END);
 		if (size == -1)
-			break;
+			continue;
 
 		if (buffer->attributes.offset[i] >= size) {
 			wl_resource_post_error(params_resource,
-- 
2.8.1



More information about the wayland-devel mailing list