[PATCH wayland-protocols v3 2/5] stable/viewporter: remove wp_viewport.set request

Derek Foreman derekf at osg.samsung.com
Thu Apr 28 18:28:32 UTC 2016


On 26/04/16 07:50 AM, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> Remove the old, redundant request. The new way is to call both
> wp_viewport.set_source and wp_viewport.set_destination when you want to
> set everything.

Makes sense.  It's all made atomic by the surface commit anyway...

> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> Reviewed-by: Daniel Stone <daniels at collabora.com>

Reviewed-by: Derek Foreman <derekf at osg.samsung.com>

> ---
>  stable/viewporter/viewporter.xml | 27 ---------------------------
>  1 file changed, 27 deletions(-)
> 
> diff --git a/stable/viewporter/viewporter.xml b/stable/viewporter/viewporter.xml
> index 0e482a6..e4322bd 100644
> --- a/stable/viewporter/viewporter.xml
> +++ b/stable/viewporter/viewporter.xml
> @@ -133,33 +133,6 @@
>               summary="negative or zero values in width or height"/>
>      </enum>
>  
> -    <request name="set">
> -      <description summary="set the crop and scale state">
> -	Set both source rectangle and destination size of the associated
> -	wl_surface. See wl_viewport for the description, and relation to
> -	the wl_buffer size.
> -
> -	The bad_value protocol error is raised if src_width or
> -	src_height is negative, or if dst_width or dst_height is not
> -	positive.
> -
> -	The crop and scale state is double-buffered state, and will be
> -	applied on the next wl_surface.commit.
> -
> -	Arguments dst_x and dst_y do not exist here, use the x and y
> -	arguments to wl_surface.attach. The x, y, dst_width, and dst_height
> -	define the surface-local coordinate system irrespective of the
> -	attached wl_buffer size.
> -      </description>
> -
> -      <arg name="src_x" type="fixed" summary="source rectangle x"/>
> -      <arg name="src_y" type="fixed" summary="source rectangle y"/>
> -      <arg name="src_width" type="fixed" summary="source rectangle width"/>
> -      <arg name="src_height" type="fixed" summary="source rectangle height"/>
> -      <arg name="dst_width" type="int" summary="surface width"/>
> -      <arg name="dst_height" type="int" summary="surface height"/>
> -    </request>
> -
>      <request name="set_source" since="2">
>        <description summary="set the source rectangle for cropping">
>  	Set the source rectangle of the associated wl_surface. See
> 



More information about the wayland-devel mailing list