[PATCH wayland* weston 00/10] hyphenate compound adjectives

[Pekka Paalanen]

On Thu, 28 Apr 2016 18:22:03 -0700
Bryce Harrington <bryce at osg.samsung.com> wrote:

> On Thu, Apr 28, 2016 at 11:57:51AM -0500, Yong Bakos wrote:
> > From: Yong Bakos <ybakos at humanoriented.com>
> > 
> > The following ten patches:
> > 
> > 1) hyphenate all occurrences of surface local and window local
> > 2) remove 'local' from one occurrence of 'buffer local' where the use of
> >    'local' is superfluous.
> > 3) correct minor grammar errors within lines changed by 1 above
> > 
> > The patches affect wayland, weston, wayland-web and wayland-protocols,
> > per recent discussion. In all cases, these are only documentation changes,
> > and patch 10/10 is the one that affects wayland.xml.
> > 
> > The rationale is that 'foo local coordinates' uses a compound adjective,
> > 'foo local', which should be hyphenated. Standardizing upon the correct
> > grammar helps authors adhere to what is correct.
> > 
> > In addition to consulting the existing precedent in Wayland projects, I also
> > consulted the 'greater literature', which indicates that:
> > 
> > 1) 'surface local' is common, but also grammatically incorrect
> > 2) 'window-local' is common
> > 3) 'buffer local', in any form, is not common (at all) and is superfluous
> > 
> > Patch summary:
> > 
> > wayland-web, Yong Bakos (1):
> >   architecture: Hyphenate compound adjective window-local
> > 
> >  architecture.html | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > weston, Yong Bakos (5):
> >   desktop-shell: Use 'surface-local' to correct grammar
> >   fullscreen-shell: Use 'surface-local' to correct grammar
> >   ivi-layout: Correct coordinate adjective grammar, misspellings
> >   ivi-application: Hyphenate compound adjective surface-local
> >   compositor: Hyphenate compound adjective surface-local
> > 
> >  desktop-shell/shell.c               |  2 +-
> >  fullscreen-shell/fullscreen-shell.c |  2 +-
> >  ivi-shell/ivi-layout.c              | 16 ++++++++--------
> >  protocol/ivi-application.xml        |  2 +-
> >  src/compositor.c                    |  2 +-
> >  5 files changed, 12 insertions(+), 12 deletions(-)
> > 
> > wayland-protocols, Yong Bakos (2):
> >   pointer-constraints: Use 'surface-local' in simplified parameter
> >     summary
> >   tablet: Hyphenate compound adjective surface-local
> > 
> >  .../pointer-constraints/pointer-constraints-unstable-v1.xml    |  4 ++--
> >  unstable/tablet/tablet-unstable-v1.xml                         | 10 +++++-----
> >  2 files changed, 7 insertions(+), 7 deletions(-)
> > 
> > wayland, Yong Bakos (2):
> >   doc: Hyphenate compound adjectives window-local, surface-local
> >   protocol: Hyphenate compound adjective surface-local  
> 
> For the full collection:
> 
> Reviewed-by: Bryce Harrington <bryce at osg.samsung.com>
> 
> Will go ahead and land it tomorrow if there are no objections.

Go ahead. If you want, you could even add
Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

I only skimmed through the patches.


Thanks,
pq


> >  doc/publican/sources/Architecture.xml |  4 +--
> >  doc/publican/sources/Protocol.xml     |  2 +-
> >  protocol/wayland.xml                  | 50 +++++++++++++++++------------------
> >  3 files changed, 28 insertions(+), 28 deletions(-)
> > 
> > -- 
> > 2.7.2
> > 
> > _______________________________________________
> > wayland-devel mailing list
> > wayland-devel at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/wayland-devel  
> _______________________________________________
> wayland-devel mailing list
> wayland-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/wayland-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 811 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20160429/f2c6cd9b/attachment-0001.sig>