[PATCH libinput 08/13] test: drop the sysname comparison in the device add/remove test

Peter Hutterer peter.hutterer at who-t.net
Tue Aug 2 02:40:53 UTC 2016


Running tests in parallel virtually guarantees a different device is added in
between. What we're testing here is that the device comes back and the
original ref doesn't send events, so a false test failure would still indicate
a bug anyway.

Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
---
 test/device.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/test/device.c b/test/device.c
index 01f794f..82ef03b 100644
--- a/test/device.c
+++ b/test/device.c
@@ -296,7 +296,7 @@ START_TEST(device_reenable_syspath_changed)
 {
 	struct libinput *li;
 	struct litest_device *litest_device;
-	struct libinput_device *device1, *device2;
+	struct libinput_device *device1;
 	enum libinput_config_status status;
 	struct libinput_event *event;
 
@@ -315,12 +315,6 @@ START_TEST(device_reenable_syspath_changed)
 	litest_drain_events(li);
 
 	litest_device = litest_add_device(li, LITEST_MOUSE);
-	device2 = litest_device->libinput_device;
-	/* Note: if the sysname isn't the same, some other device got added
-	 * or removed while this test was running.  This is unlikely and
-	 * would result in a false positive, so let's fail the test here */
-	ck_assert_str_eq(libinput_device_get_sysname(device1),
-			 libinput_device_get_sysname(device2));
 
 	status = libinput_device_config_send_events_set_mode(device1,
 			LIBINPUT_CONFIG_SEND_EVENTS_ENABLED);
-- 
2.7.4



More information about the wayland-devel mailing list