[PATCH weston v3 3/3] libweston: remove pkgincludedir variable from libweston.pc

[Quentin Glidic]

On 22/07/2016 15:51, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
>
> Common practise it to provide the includes directly into Cflags, hence
> the variable is not needed and we can remove it.
>
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
> Replaces the "libweston: do not add libweston-$version to the Cflags"
> patch.
> ---

Still don’t like to remove a variable to hide the value in Cflags: where 
it is more likely to be missed.
Anyway, you did care enough to remove such a thing, so if it proves to 
be an error later, I will care enough to re-add it:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Cheers,


>  libweston/libweston.pc.in | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libweston/libweston.pc.in b/libweston/libweston.pc.in
> index 24fe813..34afb0d 100644
> --- a/libweston/libweston.pc.in
> +++ b/libweston/libweston.pc.in
> @@ -2,11 +2,10 @@ prefix=@prefix@
>  exec_prefix=@exec_prefix@
>  libdir=@libdir@
>  includedir=@includedir@
> -pkgincludedir=${includedir}/libweston- at LIBWESTON_ABI_VERSION@
>
>  Name: libweston API
>  Description: Header files for libweston compositors development
>  Version: @WESTON_VERSION@
>  Requires.private: wayland-server pixman-1 xkbcommon
> -Cflags: -I${pkgincludedir}
> +Cflags: -I${includedir}/libweston- at LIBWESTON_ABI_VERSION@
>  Libs: -L${libdir} -lweston- at LIBWESTON_ABI_VERSION@
>


-- 

Quentin “Sardem FF7” Glidic